-
Notifications
You must be signed in to change notification settings - Fork 36
Update sphinx theme #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sphinx theme #348
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
==========================================
+ Coverage 90.36% 90.42% +0.06%
==========================================
Files 41 41
Lines 2988 3008 +20
==========================================
+ Hits 2700 2720 +20
Misses 288 288 ☔ View full report in Codecov by Sentry. |
I added a more organized and concrete contribution guide and eliminated some redundancy in the GH, PyPI, and RTD landing pages. Hopefully this addresses the reviewer's comments in our JOSS submission. |
This theme is visually more pleasing. I just find two downsides to it:
Is there a way to change that? |
Agree with Max, we should work on the top and side nav bars. |
Okay, I think it would make sense to split this into 2 PRs: this one will update the contributing guide and up-version sphinx, and a future PR will change the theme. How does this sound? |
Yeah that makes more sense. Thanks Nich. |
Based on @leotrs suggestion.